Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/xyz.character nas #451

Merged
merged 3 commits into from Dec 11, 2020
Merged

Fix/xyz.character nas #451

merged 3 commits into from Dec 11, 2020

Conversation

jefferis
Copy link
Collaborator

@alexanderbates this is an important fix that could affect your spreadsheet updates. Specifically xyzmatrix.character() was previously silently dropping rows with no/bad values. If these results were then used to calculate e.g. new ids in another column without checking the number of replacement values, they would end up misaligned.

* this was dangerous behaviour as people might have used it update e.g. google sheets columns assuming no rows were dropped
* with test
@alexanderbates
Copy link
Collaborator

Noted!

@jefferis
Copy link
Collaborator Author

The CI failure is nothing to do with this change, but rather due to changes in rgl::wire3d. I will need to update the docs, but more generally, I wonder if we should be removing wire3d()

codoc mismatches from documentation object 'wire3d':
wire3d.mesh3d
  Code: function(x, ..., front = "lines", back = "lines")
  Docs: function(x, override = TRUE, meshColor = c("vertices", "edges",
                 "faces", "legacy"), ...)
  Argument names in code not in docs:
    front back
  Argument names in docs not in code:
    override meshColor
  Mismatches in argument names:
    Position: 2 Code: ... Docs: override
    Position: 3 Code: front Docs: meshColor
    Position: 4 Code: back Docs: ...

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 81.312% when pulling f56a80a on fix/xyz.character-nas into 0efa75b on master.

@jefferis jefferis merged commit 38dcf0d into master Dec 11, 2020
@jefferis jefferis deleted the fix/xyz.character-nas branch December 11, 2020 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants