Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[add] ntrees to summary #462

Merged
merged 3 commits into from
May 28, 2021
Merged

[add] ntrees to summary #462

merged 3 commits into from
May 28, 2021

Conversation

dokato
Copy link
Contributor

@dokato dokato commented May 28, 2021

Addresses #461.
Summary of neuron prints nTrees now.

@coveralls
Copy link

coveralls commented May 28, 2021 •
edited

Coverage Status

Coverage increased (+0.003%) to 81.456% when pulling bcc0eba on dokato:summary_add into fe2f7b8 on natverse:master.

jefferis
jefferis requested changes May 28, 2021
View reviewed changes
Copy link
Collaborator

@jefferis jefferis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small requests in comments. Could you also

  • Add yourself to description as ctb
  • Add NEWS entry referencing this issue

Thank you!

R/summary.R Outdated Show resolved Hide resolved
R/summary.R Outdated Show resolved Hide resolved
tests/testthat/test-summary.R Show resolved Hide resolved
@dokato
Copy link
Contributor Author

dokato commented May 28, 2021

All done, PTAL now.

jefferis
jefferis approved these changes May 28, 2021
View reviewed changes
Copy link
Collaborator

@jefferis jefferis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you!

@jefferis jefferis merged commit b3dd4e4 into natverse:master May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefferis jefferis jefferis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dokato @coveralls @jefferis