Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neurons matched by first column in case of generic row names in… #467

Merged
merged 9 commits into from May 20, 2022

Conversation

dokato
Copy link
Contributor

@dokato dokato commented Jun 10, 2021

Neurons matched by the first column in case of generic row names in data.frame - following yours yesterday's idea.

@coveralls
Copy link

coveralls commented Jun 10, 2021

Coverage Status

Coverage increased (+0.02%) to 81.441% when pulling 8153c04 on dokato:neuronlistindex into a155984 on natverse:master.

R/neuronlist.R Outdated Show resolved Hide resolved
tests/testthat/test-neuronlist.R Outdated Show resolved Hide resolved
R/neuronlist.R Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 11, 2021

Codecov Report

Merging #467 (ae03ae5) into master (8d8b28c) will decrease coverage by 0.04%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #467      +/-   ##
==========================================
- Coverage   76.95%   76.91%   -0.05%     
==========================================
  Files          47       47              
  Lines        5842     5848       +6     
==========================================
+ Hits         4496     4498       +2     
- Misses       1346     1350       +4     
Impacted Files Coverage Δ
R/neuronlist.R 81.30% <85.71%> (-0.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d8b28c...ae03ae5. Read the comment docs.

@jefferis
Copy link
Collaborator

@dokato I'm sorry this PR got dropped. Do you think it's still ready for merge?

@dokato
Copy link
Contributor Author

dokato commented Apr 21, 2022

Yes, I tested it even now, it should be okay.

@jefferis jefferis merged commit 49d578d into natverse:master May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants