BUG: calculate range of active scalar

Getting the scalar range on the poly data was returning an incorrect tuple. Get the range of the active scalar array instead. Issue #3672
naucoin · May 16, 2014 · 068c624 · 068c624
1 parent 979d08b
commit 068c624
Show file tree

Hide file tree

Showing 3 changed files with 61 additions and 6 deletions.
diff --git a/Modules/Loadable/TractographyDisplay/MRML/vtkMRMLFiberBundleGlyphDisplayNode.cxx b/Modules/Loadable/TractographyDisplay/MRML/vtkMRMLFiberBundleGlyphDisplayNode.cxx
@@ -25,6 +25,7 @@ Version:   $Revision: 1.3 $
 #include <vtkAssignAttribute.h>
 #include <vtkCallbackCommand.h>
 #include <vtkObjectFactory.h>
+#include <vtkPointData.h>
 #include <vtkVersion.h>
 
 //----------------------------------------------------------------------------
@@ -142,7 +143,6 @@ void vtkMRMLFiberBundleGlyphDisplayNode::UpdatePolyDataPipeline()
 
   if (!this->Visibility)
     {
-    std::cout << "no visibility" << std::endl;
     return;
     }
 
@@ -283,7 +283,18 @@ void vtkMRMLFiberBundleGlyphDisplayNode::UpdatePolyDataPipeline()
 #else
         this->GetOutputPolyDataConnection()->GetProducer()->Update();
 #endif
-        this->GetOutputPolyData()->GetScalarRange(range);
+        vtkPointData *pointData = this->GetOutputPolyData()->GetPointData();
+        if (pointData &&
+            pointData->GetArray(this->GetActiveScalarName()))
+          {
+          double *activeScalarRange = pointData->GetArray(
+            this->GetActiveScalarName())->GetRange();
+          if (activeScalarRange)
+            {
+            range[0] = activeScalarRange[0];
+            range[1] = activeScalarRange[1];
+            }
+          }
         }
       }
 

diff --git a/Modules/Loadable/TractographyDisplay/MRML/vtkMRMLFiberBundleLineDisplayNode.cxx b/Modules/Loadable/TractographyDisplay/MRML/vtkMRMLFiberBundleLineDisplayNode.cxx
@@ -282,7 +282,18 @@ void vtkMRMLFiberBundleLineDisplayNode::UpdatePolyDataPipeline()
 #else
           this->GetOutputPolyDataConnection()->GetProducer()->Update();
 #endif
-          this->GetOutputPolyData()->GetScalarRange(range);
+          vtkPointData *pointData = this->GetOutputPolyData()->GetPointData();
+          if (pointData &&
+              pointData->GetArray(this->GetActiveScalarName()))
+            {
+            double *activeScalarRange = pointData->GetArray(
+              this->GetActiveScalarName())->GetRange();
+            if (activeScalarRange)
+              {
+              range[0] = activeScalarRange[0];
+              range[1] = activeScalarRange[1];
+              }
+            }
           }
         }
       if ((this->GetColorMode ( ) == vtkMRMLFiberBundleDisplayNode::colorModeMeanFiberOrientation) ||
@@ -299,7 +310,18 @@ void vtkMRMLFiberBundleLineDisplayNode::UpdatePolyDataPipeline()
 #else
         this->GetInputPolyDataConnection()->GetProducer()->Update();
 #endif
-        this->GetInputPolyData()->GetScalarRange(range);
+        vtkPointData *pointData = this->GetOutputPolyData()->GetPointData();
+        if (pointData &&
+            pointData->GetArray(this->GetActiveScalarName()))
+          {
+          double *activeScalarRange = pointData->GetArray(
+            this->GetActiveScalarName())->GetRange();
+          if (activeScalarRange)
+            {
+            range[0] = activeScalarRange[0];
+            range[1] = activeScalarRange[1];
+            }
+          }
         }
       //this->ScalarRange[0] = range[0];
       //this->ScalarRange[1] = range[1];

diff --git a/Modules/Loadable/TractographyDisplay/MRML/vtkMRMLFiberBundleTubeDisplayNode.cxx b/Modules/Loadable/TractographyDisplay/MRML/vtkMRMLFiberBundleTubeDisplayNode.cxx
@@ -326,7 +326,18 @@ void vtkMRMLFiberBundleTubeDisplayNode::UpdatePolyDataPipeline()
 #else
         this->GetOutputPolyDataConnection()->GetProducer()->Update();
 #endif
-        this->GetOutputPolyData()->GetScalarRange(range);
+        vtkPointData *pointData = this->GetOutputPolyData()->GetPointData();
+        if (pointData &&
+            pointData->GetArray(this->GetActiveScalarName()))
+          {
+          double *activeScalarRange = pointData->GetArray(
+            this->GetActiveScalarName())->GetRange();
+          if (activeScalarRange)
+            {
+            range[0] = activeScalarRange[0];
+            range[1] = activeScalarRange[1];
+            }
+          }
         }
       }
     else if ((this->GetColorMode ( ) == vtkMRMLFiberBundleDisplayNode::colorModeMeanFiberOrientation) ||
@@ -343,7 +354,18 @@ void vtkMRMLFiberBundleTubeDisplayNode::UpdatePolyDataPipeline()
 #else
       this->GetInputPolyDataConnection()->GetProducer()->Update();
 #endif
-      this->GetInputPolyData()->GetScalarRange(range);
+      vtkPointData *pointData = this->GetOutputPolyData()->GetPointData();
+      if (pointData &&
+          pointData->GetArray(this->GetActiveScalarName()))
+        {
+        double *activeScalarRange = pointData->GetArray(
+            this->GetActiveScalarName())->GetRange();
+        if (activeScalarRange)
+          {
+          range[0] = activeScalarRange[0];
+          range[1] = activeScalarRange[1];
+          }
+        }
       }
     //this->ScalarRange[0] = range[0];
     //this->ScalarRange[1] = range[1];