Sign NAudio assembly #677
Closed
Sign NAudio assembly #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change creates a strong-named version of NAudio.dll. While this doesn't have any benefits in regards to security it helps those projects that (for whatever reason) are required to create strong-named assemblies because all dependencies have to be strong-named as well.
|
The new NAudio 2 (currently in beta) will used strong named assemblies. Please let me know if that meets your needs |
|
Yes, that helps. Thanks! But it still would be good to have it available in v1 as well - I haven't checked what changed between v1 and v2, but the major version number change suggests that there are breaking changes that not every project can make immediately. And v2 is still in beta, whereas it should be possible to release a new stable v1 package right away (with the only change being that it is now signed). |
|
NAudio v2 will be highly compatible. All the same classes, with same names and same namespaces, just organized into different assembly groupings (which are strongly typed). |
|
OK, sounds good. I'll close this one then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change creates a strong-named version of NAudio.dll. While this
doesn't have any benefits in regards to security it helps those projects
that (for whatever reason) are required to create strong-named assemblies
because all dependencies have to be strong-named as well.