Missing ServiceResult returns of CheckServiceFaultResponse() in Client.cs

[Christ0ph89]

Hi Nauful,

I was struggling with a strange problem, which turned out to be a mistake of a wrong uri in the certificate (missing letter...).
All the time I've tried to open a new session to the OPC UA server of our S7 PLC, I received the ServiceResult "2149908480" (BadSessionIdInvalid), which is not correct for that specific problem. The correct ServiceResult is "2148990976" (BadCertificateUriInvalid).

At the end I was able to get the correct ServiceResult by setting breakpoints at the right positions in the Client.cs source file. But there I saw, that there is maybe a, or some, missing "return" in the library, to receive the correct ServiceResult. All the time the method CheckServiceFaultResponse() is used, there is no return or handling of the service code that it responses. After changing, in my case the line 1919 in the Client.cs to return CheckServiceFaultResponse(recvHandler);, I was able to return the correct status code to the upper client class and print it to the logs.

So my question is, is the returning of the status code of that method just missing or a desired behaviour? Because all occurence of that method in the Client.cs does not return the status code.

Greetings

[nauful]

Hello,

You are correct, that is indeed a bug. It was originally based on throwing exceptions and I forgot to convert this code over. I will be making some updates for that soon to fix this.

Thanks