Define the IntoIterator traits on the CS types #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the useful implementation!
|
bors bot
added a commit
to meilisearch/meilisearch
that referenced
this pull request
Jun 6, 2022
2464: Simplify the `star_or` function usage r=ManyTheFish a=Kerollmops This PR simplifies the usage of the `star_or` function that was originally introduced in #2399. The `serde-cs` naughie/serde-cs#1 PR was merged and was implementing the `IntoIterator` trait on the `CS` types, which makes it possible to directly collect without converting a `CS` into the inner type (vec). Co-authored-by: Kerollmops <clement@meilisearch.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found it useful to declare the
IntoIteratortrait on these twoCStypes, I no more need to call.into_inner().into_iter()and can pass thisCStype to any function accepting anIntoIterator<Item = T>instead of converting it.However, the array implementation of
IntoIteratorthat returned owned types is quite recent and has been released in the 1.53 version of Rust, I don't know if we want to bump the MSRV of this crate and if we don't: how can we make it conditional to the version of Rust the user is using.