Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strictlyNew = false error #24

Closed
bormat opened this issue Dec 11, 2016 · 2 comments
Closed

strictlyNew = false error #24

bormat opened this issue Dec 11, 2016 · 2 comments

Comments

@bormat
Copy link

bormat commented Dec 11, 2016

Hi,
Setting strictlyNew to false seems to create the error "Cannot read property 'parentNode' of null(…)"
The incriminated function is topmostUntaggedParent which continue recursive call even when they are no parentNode.
I use chrome.

<div class="b0 test"></div>

<script>
	insertionQ.config({
	    strictlyNew : false,
	    timeout : 0,
	});
	insertionQ('.test').summary(function(arrayOfInsertedNodes){
	    console.log(arrayOfInsertedNodes)
	});
	setTimeout(function(){
		$('<div class="b1 test"></div>').appendTo('body')
	},1000)

</script>

Thanks

@naugtur
Copy link
Owner

naugtur commented Dec 11, 2016

hmm... it was supposed to recognize when it reaches the top. Thanks for reporting, I'll look into it.

@naugtur
Copy link
Owner

naugtur commented Jan 13, 2017

Fixed, published v1.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants