Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #125

Merged
merged 9 commits into from
Nov 13, 2020
Merged

Develop #125

merged 9 commits into from
Nov 13, 2020

Conversation

cjdsellers
Copy link
Member

No description provided.

cjdsellers and others added 9 commits November 12, 2020 12:35
@cjdsellers
Value object API change
92d7a33 
- Change value object base class name to BaseDecimal
- Move BaseDecimal into model.objects
- More explicitness in use of decimal.Decimal and BaseDecimal
- Change filled_qty to fill_qty for clarity
- Remove redundant _sum_net_position method
- Fix tests
@cjdsellers
Add type checks for decimal.Decimal
3354c03 
- Explicitly call decimal.Decimal within test suite
- Fix average price typing on fill event
@mLewisLogic
cleanup build/publish
e2d2e45
@cjdsellers
Merge pull request #123 from nautechsystems/mlewis--build-cleanup
baa0d5e 
Build cleanup
@cjdsellers
Add SimulationModule concept
f0741b1 
- Move _internal data to test_kit
- Make simulation modules optionally pluggable to engine
- Improve injection of data into reliant classes
- Added TODOs for refactoring
@cjdsellers
Add Python 3.9 to CI builds
7faf02e
@cjdsellers
Add Python 3.9 to CI builds
57a7335
@cjdsellers
Consolidate BaseDecimal testing
9799d26 
- Move tests to appropriate location
- Test rounding mode is working
@cjdsellers
Release
be7a2a2 
- Early release for new API adoption
- Clarify rounding rule
- Add instrument unit tests
@cjdsellers
Copy link
Member Author

cjdsellers commented Nov 13, 2020 •
edited
Loading

For the math ops involving BaseDecimal, the decimal.Decimal needs to be extracted out. If the object in question is on the right side of the expression then you can no longer call self as that param name shadows self with the incoming left side arg. I'll see if I can clean this up going with a, b and getting ride of the @staticmethods

@cjdsellers cjdsellers merged commit b445b7d into master Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cjdsellers @mLewisLogic