Develop #132
Merged
Develop #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add meaningful exceptions to identifier from_string methods - Fix order serialization - Cleanup redundancy in a position method
- Remove redundant object param types - Remove a non-standard type comment
- Change OrderFilled.avg_price property name to fill_price for clarity - Standardize constants - Improve type checking - Fix order avg_price calculation - Fix docs
- Implement TradeTickDataWrangler - Generalize example strategies - Generalize instrument calculation methods - Generalize portfolio calculations - Update tests - Update docstrings
Codecov Report
@@ Coverage Diff @@
## master #132 +/- ##
==========================================
+ Coverage 84.65% 84.81% +0.15%
==========================================
Files 118 118
Lines 10205 10252 +47
==========================================
+ Hits 8639 8695 +56
+ Misses 1566 1557 -9
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.