Order by ts_init to read row groups in order #1656
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Use
ORDER BY ts_init
in default sql query. Closes #1515By default datafusion reads row groups out of order for large files. The test files use in CI are small and don't show this so it was missed. From discussion in apache/datafusion#10572, there are two ways to fix this and using ORDER BY clause is the recommended way.
Type of change
How has this change been tested?
Tested with sample data to ensure ordering is maintained.