Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix list determination, do not look for : in element node id #116

Merged
merged 2 commits into from
Oct 22, 2020

Conversation

berend
Copy link
Contributor

@berend berend commented Oct 21, 2020

This fixes #115

For Non-List results, the if block for deciding between list and single object relied on searching the path for :. This fails for object names that contains :.

The fix only looks for : in the non-Object part of the name

@AlecAivazis
Copy link
Member

Hey @berend thanks for hunting this down! Do you mind adding a test that covers this case?

@berend
Copy link
Contributor Author

berend commented Oct 22, 2020

Yes, will do, hopefully today.

also extended previous to make sure that `GetDataPoint` also works properly
@berend
Copy link
Contributor Author

berend commented Oct 22, 2020

Please have a look, @AlecAivazis

@AlecAivazis
Copy link
Member

Awesome! thank you so much. I'll go ahead and merge this in.

Btw, if you ever need to get ahold of me, i'm on the gophers slack. I'd love to know a little more about how you are using this gateway :)

@AlecAivazis AlecAivazis merged commit 6a0452e into nautilus:master Oct 22, 2020
@AlecAivazis
Copy link
Member

This should now be available under the v0.1.9 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Composing results fails for single item queries
2 participants