Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support File Uploads inside of Inputs #133

Merged
merged 4 commits into from
Apr 9, 2021

Conversation

mfinley3
Copy link
Contributor

@mfinley3 mfinley3 commented Apr 5, 2021

Closes #131

Adds support for:

scalar Upload

input FilesInput {
	files:   [Upload!]!
	file:    Upload!
}
type Mutation {
	uploadMultiInput(input: FilesInput!): [String!]!
}

Before merging this we should merge: nautilus/graphql#17 then tag the repo and update deps here

Signed-off-by: mfinley mfinley@octolabs.io

Signed-off-by: mfinley <mfinley@octolabs.io>
Signed-off-by: mfinley <mfinley@octolabs.io>
@mfinley3 mfinley3 changed the title #131 Support File Uploads inside of Inputs Support File Uploads inside of Inputs Apr 5, 2021
Signed-off-by: mfinley <mfinley@octolabs.io>
Signed-off-by: mfinley <mfinley@octolabs.io>
@mfinley3
Copy link
Contributor Author

mfinley3 commented Apr 5, 2021

@AlecAivazis Thanks for taking a look at these PRs so quickly! I've updated the nautilus/graphql version here to the latest tag you've created. Let me know if you have any feedback on these changes!

Also what would you'd like me to do about the coveralls check that's failing? I'm not quite sure where to improve the coverage; it looks like nothings been uncovered and I've appeared to hit all of the lines I added.

@AlecAivazis
Copy link
Member

@mfinley3 don't worry about the failing coveralls check, 0.007 is basically the same value. One of these days I'll look into adding some buffer to this check but I can just push it through for now.

Thanks for the contribution!

@AlecAivazis AlecAivazis merged commit 4febbae into nautilus:master Apr 9, 2021
@mfinley3
Copy link
Contributor Author

mfinley3 commented Apr 9, 2021

Awesome - thanks @AlecAivazis :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Uploads inside of Input Types
2 participants