Separate CLI and example dependencies, support 'go install' #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry i haven't found the time to test this out yet. Will try to give it a shot some time this week |
AlecAivazis
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds sub Go modules to separate dependencies a bit between the gateway library, the CLI, and its examples.
I noticed the
mainpackage was located in./cmdand had trouble installing viago installsince it was being namedcmd.I went ahead and moved it into subdirectory with the desired name mentioned here: #146 (comment)
I also documented how to install it from this location.
One notable caveat: The new
cmd/gatewaygo.mod file points to a specific version of the gateway library, which could become outdated. I considered adding areplacepointing to a parent directory, but I don't think this supportsgo install <full pkg name>.Fixes #149