Bugfix/make share file null again #159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f43631b.
…ire schema in introspection queries
…ion points are mutated by multiple go routines - happens only when there are multiple queries being spawned for different insertion points, e.g. both FederatedInitiative and FederatedFile in Manufacturer - fixed by just making a copy of the startingPoints (which is a reference to the step insertion points)
- I think when a sub-query finishes to quickly it can cause the go routine(the one accumulating the result) in Execute to finish too early, leaving insertionPoints in the final returned result unresolved although their sub-queries queries were successful(or are still running at that point) - the issue can be best reproduced by running go test -v -count=1 -race github.com/nautilus/gateway -run TestExecutor_insertIntoLists - after this fix I ran the -race test for hundreds of times without seeing the issue againg
Feature/upstream merge
…escriptions to warnings
bugfix/dont-error-descriptions
…i returned nothing
… fill in default types for fields not allowed to be null
Bugfix/invariant violation 8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.