Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with Go 1.18, compatible with Go 1.13 #161

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

JohnStarich
Copy link
Member

  • Bumps the Go version for builds to the latest, Go 1.18.
  • Fixes golang.org/x/sys version for Go 1.18.
  • The go X.Y line in go.mod enforces our backward compatibility guarantee. Documented in README now.

@JohnStarich
Copy link
Member Author

Hey @AlecAivazis! I started taking a look at doing #143 and hit some issues with the latest version of Go.

The golang.org/x/sys change was the main thing. I thought it might be nice to upgrade the build system as well to catch issues like that one.

If you like, I can extend it in GitHub Actions to run tests on several different Go versions too.

@AlecAivazis
Copy link
Member

Thanks for updating this @JohnStarich! I'll go ahead and merge/deploy it with these changes and you can add more environments in a separate PR - sound good?

@AlecAivazis AlecAivazis merged commit 73f53ac into nautilus:master Jun 15, 2022
@JohnStarich JohnStarich deleted the feature/build-go-latest branch June 15, 2022 21:31
@JohnStarich
Copy link
Member Author

Sounds good! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants