Fix panics on non-GET/non-POST requests #186
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack trace from the original panic:
It failed to form a response because none had been created. This PR prevents further execution when the HTTP method is not supported.
The GraphQL over HTTP working draft provides a little bit of clarity here, though stops short of defining non-GET and non-POST response status codes.
Given most servers return 405 Method Not Allowed in these kinds of scenarios and it is certainly better than panicking (typically with a 500 error), I think this is the right move for now.