Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix-return-with-error #98

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Fix-return-with-error #98

merged 1 commit into from
Mar 25, 2020

Conversation

longquan0104
Copy link
Contributor

No description provided.

@AlecAivazis
Copy link
Member

Hey @longquan0104!

Mind providing me a little more detail why this change is necessary? The actual value should be ignored if there is a non-nil error so I try to just return nil whenever appropriate.

@longquan0104
Copy link
Contributor Author

Due to Apollo use case if service(s) dies, the gateway still response the data of the alive services with the errors. The Execute function only return errors without data. I just tried to make it more like Apollo federation.

@AlecAivazis
Copy link
Member

Makes sense! Thanks again 👍

@AlecAivazis AlecAivazis merged commit 95b0199 into nautilus:master Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlecAivazis AlecAivazis AlecAivazis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@longquan0104 @AlecAivazis