Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introspect Remote Schemas with options #16

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

SVilgelm
Copy link
Contributor

Add new IntrospectRemoteSchemasWithOptions function to keep the IntrospectRemoteSchemas function backward compatible.
The new function accepts the list of urls and the Introspect Options.

Add the Introspect Options:

  • IntrospectWithMiddlewares to use custom network middlewares
  • IntrospectWithHTTPClient to use a custom http client
  • IntrospectWithContext to use a custom global context

Update the IntrospectAPI function to accept the introspect options.

Add new `IntrospectRemoteSchemasWithOptions` function to keep the `IntrospectRemoteSchemas` function backward compatible.
The new function accepts the list of urls and the Introspect Options.

Add the Introspect Options:
* IntrospectWithMiddlewares to use custom network middlewares
* IntrospectWithHTTPClient to use a custom http client
* IntrospectWithContext to use a custom global context

Update the `IntrospectAPI` function to accept the introspect options.
@SVilgelm
Copy link
Contributor Author

@AlecAivazis Hi, Could you please review this PR?
I see a question about the passing middleware was raised several times and I had to implement own version of IntrospectRemoteSchemas function to pass the middlewares and use a custom http client (we need to use the custom certificates). So I think it will be better to have such functionality right here

@SVilgelm
Copy link
Contributor Author

@AlecAivazis would you be able to review this PR?

introspection.go Show resolved Hide resolved
@AlecAivazis
Copy link
Member

Hey @SVilgelm! Thanks for being patient :) just a quick comment on the proposed API but we should be able to get this in quickly

@SVilgelm
Copy link
Contributor Author

Hey @SVilgelm! Thanks for being patient :) just a quick comment on the proposed API but we should be able to get this in quickly

no worries, thank you for you response

@AlecAivazis
Copy link
Member

Im going to merge this in now even tho travis is complaining. I'll get to the bottom of the issue once this is released

@AlecAivazis AlecAivazis merged commit b987a48 into nautilus:master Feb 24, 2021
@SVilgelm SVilgelm deleted the introspection-with-options branch February 24, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants