feat: added option to specify error pubtopic #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xytxytxyt
commented
Oct 18, 2022
| @@ -80,6 +81,9 @@ def topics(dot: graphviz.Digraph, configs: List[Dict[str, Union[None, str, List[ | |||
| for topic_element in format_topic('pubtopic', config): | |||
| dot.edge(format_component(config)[0], topic_element[0]) | |||
| dot.node(*topic_element, shape='box') | |||
| for topic_element in format_topic('error_pubtopic', config): | |||
| dot.edge(format_component(config)[0], topic_element[0]) | |||
| dot.node(*topic_element, shape='octagon') | |||
There was a problem hiding this comment.
chose octagon because it is used for stop signs: http://www.trafficsign.us/signshape.html
sample:
xytxytxyt
commented
Oct 18, 2022
| @@ -12,3 +12,4 @@ requests | |||
| docker | |||
| pytest | |||
| pytest-timeout | |||
| importlib-metadata==4.13.0 | |||
There was a problem hiding this comment.
zachschubert
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently in ergo it is not possible for a component to subscribe to the error queues of multiple components
this feature is useful for a 3rd party outage detector that we're working on that will subscribe to errors from api connectors, categorize them, and report them to slack
this pr adds this feature