Add display of wallet changes to TxSignView #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* No ERG present among tokens yet
* ERG is always displayed first now. * Use BigNumber methods instead of BigInts. * Remove redundant comments, add some new.
capt-nemo429
requested changes
May 6, 2023
There was a problem hiding this comment.
Some remarks on incoming/leaving assets summary:
- Please, move the calculation logic from
TxSignSummary.vuetoTxInterpreterand expose two properties, namely:totalIncomingandtotalLeaving, so that we can only display the summary where it makes sense in the future. - You can make use of
utxoSumandutxoSumResultDifffunctions from@fleet-sdk/commonpackage to make the code a bit more concise and cleaner.
* Move delta calculation from TxSignSummary to txInterpreter. * Expose new properties totalIncoming and totalLeaving in txInterpreter. * Use utxoSum and utxoSumResultDiff for deltas calculation. * Extract some parts of the calculation to a separate utils file under transaction interpreter. * Some local functions defined in _determineChangeBoxes in txInterpreter were also needed for _calcIncomingLeavingTotals, so there are slight changes to change box function as well.
capt-nemo429
requested changes
May 7, 2023
capt-nemo429
approved these changes
May 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
TxSignSummarycomponent for displayingchanges to own wallet. There are two new boxes
displayed. One green for newly incoming assets and
one red for assets leaving the wallet.
For example, if there are 10 ERG incoming
to the wallet, but in the same tx, 3 ERG are
leaving the wallet, then there will be 7 ERG
displayed in the green box and the red box
will be empty.