Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ssl_verify to align with pynautobot in a version compatible with Nautobot v1.x #341

Closed
wants to merge 9 commits into from

Conversation

joaopsys
Copy link

Basically applying this PR - #269 - to the LTM nautobot-ansible release since #269 was only applied on versions compatible with Nautobot v2

Without this change, nautobot-ansible 4.5.0 doesn't work when used with the latest version of Nautobot LTM (1.6.x) as well as pynautobot 1.5.x

@joewesch
Copy link
Contributor

Similar to the PR you linked, we should update pynautobot to ^1.5.1 for poetry as it includes the SSL change.

@joewesch
Copy link
Contributor

Actually, go ahead and change it to ^1.5.2 to deal with the new auth changes as well.

@joaopsys
Copy link
Author

Actually, go ahead and change it to ^1.5.2 to deal with the new auth changes as well.

Done!

@joewesch
Copy link
Contributor

Please run a poetry lock to generate a new lock file as well.

@joaopsys
Copy link
Author

Please run a poetry lock to generate a new lock file as well.

I noticed the pyproject.toml I was using (straight from https://github.com/nautobot/nautobot-ansible/tree/v4.5.0) was not the same as the one in https://github.com/nautobot/nautobot-ansible/tree/ltm-1.6 so I have updated it now to match and ran poetry lock as advised. Let me know if there's anything else I should do

@joewesch
Copy link
Contributor

It is still showing file conflicts. You may want to rebase off ltm-1.6.

@joaopsys
Copy link
Author

Let's try this again :) #344

@joaopsys joaopsys closed this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants