[Housekeeping] Viewsets migration #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzbroch
force-pushed
the
mzb-jwhite-viewset
branch
2 times, most recently
from
72adb58
to
582afe7
Compare
Closed
| @@ -318,7 +341,8 @@ class PeerGroup(PrimaryModel, InheritanceMixin, BGPExtraAttributesMixin): | |||
|
|
|||
| name = models.CharField(max_length=100) | |||
|
|
|||
| template = models.ForeignKey( | |||
| # Rename to avoid clash with DRF renderer | |||
There was a problem hiding this comment.
Huh. What was the issue here?
Comment on lines
-65
to
-75
| path("peering-roles/edit/", views.PeeringRoleBulkEditView.as_view(), name="peeringrole_bulk_edit"), | ||
| path("peering-roles/delete/", views.PeeringRoleBulkDeleteView.as_view(), name="peeringrole_bulk_delete"), | ||
| path("peering-roles/<slug:slug>/", views.PeeringRoleView.as_view(), name="peeringrole"), | ||
| path("peering-roles/<slug:slug>/edit/", views.PeeringRoleEditView.as_view(), name="peeringrole_edit"), | ||
| path("peering-roles/<slug:slug>/delete/", views.PeeringRoleDeleteView.as_view(), name="peeringrole_delete"), | ||
| path( | ||
| "peering-roles/<slug:slug>/changelog/", | ||
| ObjectChangeLogView.as_view(), | ||
| name="peeringrole_changelog", | ||
| kwargs={"model": models.PeeringRole}, | ||
| ), |
There was a problem hiding this comment.
Is nautobot/nautobot#3663 an issue for any of the converted views?
mzbroch
force-pushed
the
mzb-jwhite-viewset
branch
from
eeb8426
to
a019a37
Compare
Add BGPRoutingInstance status field Add CSV import and export
mzbroch
force-pushed
the
mzb-jwhite-viewset
branch
from
a019a37
to
cc9bcb2
Compare
|
@whitej6 @glennmatthews Please re-review. Sorry for the long PR. :( |
glennmatthews
approved these changes
Jun 16, 2023
|
|
||
| import nautobot.extras.forms as extras_forms | ||
| import nautobot.utilities.forms as utilities_forms |
There was a problem hiding this comment.
For my own education, what are we still needing to pull direct from nautobot.utilities.forms? We should look at getting those added to nautobot.apps.forms.
There was a problem hiding this comment.
import nautobot.utilities.forms as utilities_forms
utilities_forms.ColorSelect
utilities_forms.BOOLEAN_WITH_BLANK_CHOICES
utilities_forms.StaticSelect2
utilities_forms.BulkEditNullBooleanSelect
utilities_forms.StaticSelect2Multiple
nautobot_bgp_models/migrations/0003_bgproutinginstance_status.py
Outdated
Show resolved
Hide resolved
nautobot_bgp_models/migrations/0003_bgproutinginstance_status.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements features that should be here before adding support for Nautobot 2.0 :
Notesfeature on BGP models #91 )templatetopeergroup_templateon PeerGroupBGPRoutingInstance(closes Status field on BGP Routing Instance Model #97)Sorry for the very long PR ... :(