-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Housekeeping] Viewsets migration #96
Conversation
72adb58
to
582afe7
Compare
@@ -318,7 +341,8 @@ class PeerGroup(PrimaryModel, InheritanceMixin, BGPExtraAttributesMixin): | |||
|
|||
name = models.CharField(max_length=100) | |||
|
|||
template = models.ForeignKey( | |||
# Rename to avoid clash with DRF renderer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh. What was the issue here?
path("peering-roles/edit/", views.PeeringRoleBulkEditView.as_view(), name="peeringrole_bulk_edit"), | ||
path("peering-roles/delete/", views.PeeringRoleBulkDeleteView.as_view(), name="peeringrole_bulk_delete"), | ||
path("peering-roles/<slug:slug>/", views.PeeringRoleView.as_view(), name="peeringrole"), | ||
path("peering-roles/<slug:slug>/edit/", views.PeeringRoleEditView.as_view(), name="peeringrole_edit"), | ||
path("peering-roles/<slug:slug>/delete/", views.PeeringRoleDeleteView.as_view(), name="peeringrole_delete"), | ||
path( | ||
"peering-roles/<slug:slug>/changelog/", | ||
ObjectChangeLogView.as_view(), | ||
name="peeringrole_changelog", | ||
kwargs={"model": models.PeeringRole}, | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is nautobot/nautobot#3663 an issue for any of the converted views?
eeb8426
to
a019a37
Compare
Add BGPRoutingInstance status field Add CSV import and export
a019a37
to
cc9bcb2
Compare
@whitej6 @glennmatthews Please re-review. Sorry for the long PR. :( |
|
||
import nautobot.extras.forms as extras_forms | ||
import nautobot.utilities.forms as utilities_forms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my own education, what are we still needing to pull direct from nautobot.utilities.forms
? We should look at getting those added to nautobot.apps.forms
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import nautobot.utilities.forms as utilities_forms
utilities_forms.ColorSelect
utilities_forms.BOOLEAN_WITH_BLANK_CHOICES
utilities_forms.StaticSelect2
utilities_forms.BulkEditNullBooleanSelect
utilities_forms.StaticSelect2Multiple
This PR implements features that should be here before adding support for Nautobot 2.0 :
Notes
feature on BGP models #91 )template
topeergroup_template
on PeerGroupBGPRoutingInstance
(closes Status field on BGP Routing Instance Model #97)Sorry for the very long PR ... :(