Add a metric for software versions. #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kircheneer
force-pushed
the
lk-app-versions-metric
branch
from
4507cad
to
44b14c4
Compare
|
I'm concerned about the cardinality of this metric. @davidrichey84 do you think this makes sense for us to add? |
|
@Kircheneer wondering if this could be configuration setting/flag - like We should be good to leave to the user the capability of setting up the level of detail they want in their metrics |
|
@nniehoff I understand the concern, I have made the presence of the plugin/basic version numbers each toggle-able. |
Kircheneer
requested review from
glennmatthews
and removed request for
nniehoff
glennmatthews
approved these changes
Nov 23, 2022
nniehoff
approved these changes
Dec 2, 2022
whitej6
pushed a commit
that referenced
this pull request
Nov 27, 2023
* Add a metric for software versions. * Make presence of plugin versions in metrics configurable. * Update documentation and turn version metrics off by default. * Fix docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comes out like this