[NCLOUD-926] Add screenshots #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvanderaa
reviewed
Jun 27, 2023
There was a problem hiding this comment.
Would be better if we went with the documentation prefixes.
There was a problem hiding this comment.
I'm sorry, what do you mean. Can you give an example?
There was a problem hiding this comment.
192.0.2.0/24, 203.0.113.0/24, 198.51.100.0/24
https://www.auvik.com/franklyit/blog/special-ip-address-ranges/
There was a problem hiding this comment.
Not a stopper, but should use these ranges when we can in documentation.
There was a problem hiding this comment.
@jvanderaa I agree that going forward all IPs should be in the documentation range, has this been documented/discussed as part of dev-standards?
whitej6
pushed a commit
that referenced
this pull request
Nov 27, 2023
* [NCLOUD-926] Add screenshots * [NCLOUD-926] Link screenshots in docs --------- Co-authored-by: Daria Sienkiewicz <“daria.sienkiewicz@codilime.com”>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added screenshots based on https://networktocode.com/apps/capacity-metrics/