Uses settings to control ephemeral state.

[jvanderaa]

Fixes #114

Moves to use settings for ephemeral settings across all of the dispatchers for what was previously ephemeral=False.

[smk4664]

I will want to test this against the chat platforms. I am concerned about some of the Mattermost commands not working in ephemeral messages.

[jvanderaa]

Makes sense @smk4664. Note that I left the ephemeral=True settings that were already there. This was effectively a find and replace of ephemeral=False to being ephemeral=settings.PLUGINS_CONFIG["nautobot_chatops"]["send_all_messages_emphemeral"]. I will also need to run through some tests, but the concept is what I was hoping to review first.

[jvanderaa]

@glennmatthews are you good with the overall design (after I fix the calls design to what you have mentioned)? I think this will cover all of the bots then and I will only need to make the update here and not in each chatops plugin implementation.

[glennmatthews]

I'm OK with the idea of it - just want to have confidence that the specific changes being made are tested :-)

[jvanderaa]

Looking at what the code is used heavily in the additional chat framework that this request is for, the Slack send_snippet does not support sending messages ephemerally, or directly to an individual.

https://api.slack.com/methods/files.upload

The method send_large_table() uses send_snippet after building the table.

[jvanderaa]

This PR will work for Python3.7 implementation and higher at the moment, which should also work for Python3.6. But we do not have the desired state for this yet.

In order to accomplish the original goals, we may need to look at adding a DM feature.

[jvanderaa]

Working to figure out the CI (some pylint disables coming where applicable).

[glennmatthews]

I don't think we want markdown formatting to apply to send_snippet in this case - is it possible to send it as plaintext, or at least wrap it in ```\n...\n``` (similar to WebexDispatcher.send_snippet())?

[glennmatthews]

If 1.1 is now the default nautobot version, don't we need to include celery by default?

[jvanderaa]

It will be. I'm going to do the update to nautobot dev environment in a separate PR. This is a better method to have the Celery components commented out but in the code. It is just easier then to get it up and running.

[jvanderaa]

This is just an easier method to handle converting over to using 1.1 or later. When Nautobot 1.3 comes out we will make the updates to go to Python3.7 and update to the newer methods.