Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for activating docs link. #320

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Updates for activating docs link. #320

merged 1 commit into from
Jul 30, 2024

Conversation

jvanderaa
Copy link
Contributor

Fixes #319

Adds new URL path for the docs link and updates app config appropriately.

glennmatthews
glennmatthews approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks functionally correct but I'd still prefer to see this done through driftmanager rather than requiring manual updates to every app.

@smk4664 smk4664 merged commit 8f6b03d into develop Jul 30, 2024
16 checks passed
@smk4664 smk4664 deleted the update_docs_link branch July 30, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennmatthews glennmatthews glennmatthews approved these changes

@smk4664 smk4664 Awaiting requested review from smk4664 smk4664 is a code owner

@romanukes romanukes Awaiting requested review from romanukes romanukes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs Link Not Active
3 participants
@jvanderaa @glennmatthews @smk4664