Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase RawNotifications raw size and used defaults #127

Merged
merged 2 commits into from
Oct 4, 2021

Conversation

chadell
Copy link
Contributor

@chadell chadell commented Oct 4, 2021

Addresses #116

  • Use Plugin default settings
  • Increase size of raw notification stored: all the headers are included.

Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I stated in #116, to me the headers are the least intereresting part of an email notification. I'd much rather see this plugin capturing the full email body (or even just the first 4k or 8k bytes, if it's a big email) in the RawNotification.

nautobot_circuit_maintenance/__init__.py Show resolved Hide resolved
@chadell
Copy link
Contributor Author

chadell commented Oct 4, 2021

As I stated in #116, to me the headers are the least intereresting part of an email notification. I'd much rather see this plugin capturing the full email body (or even just the first 4k or 8k bytes, if it's a big email) in the RawNotification.

Yes, defaulting to 8K it's a good size to get good email representation without overwhelming the DB

@chadell chadell merged commit 0c693dd into develop Oct 4, 2021
@chadell chadell deleted the increase-rawnotification-raw-size branch October 4, 2021 15:25
itdependsnetworks pushed a commit to itdependsnetworks/nautobot-app-circuit-maintenance that referenced this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants