-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version with patch. #310
Conversation
Main to develop post 2.2.2
Updates app config and urls to populate docs link.
Fixes #311 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although it's not spelled out yet in the project docs so far as I can see, I think the usual process for a release would be to do a release-branch PR into main
(including release-note updates, etc.) rather than directly bumping the version in develop
. Happy to collaborate with you on this if needed.
So I would cut a new branch off of develop, PR that to main, then merge main back to develop? |
That's how we do things in core at least. |
I can do that then. What I've been doing on pynautobot, nautobot-ansible is: merge pieces into develop |
I guess the changelog is failing because the |
Changelog CI is failing because any PR into |
I see that the target of the PR was changed correctly to |
Ok, this was a case of not following the new documentation. I have some questions on it with one change that we should make. The part about tags. It says to create a tag. Shouldn't that be |
@chadell I think this should be all set. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The release process after this is merged should indeed be to create a Release
and in the process of doing so, have GitHub create a v2.2.3
tag
for the release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sets patch release.