Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label attribute for sorting and identifying OnboaringTasks #23

Merged
merged 1 commit into from Sep 8, 2021

Conversation

pszulczewski
Copy link

@pszulczewski pszulczewski commented Sep 1, 2021

This PR introduces the label attribute of the Onboarding Task model. Label is represented via integer value, and is a human friendly identifier of a task. Label does not replace the UUID identifier, it rather acts as a helper to easier the task identification. For the already existing tasks, migration job will assign labels starting from value of 1, sorted on the Creation Time of those.

nautobot_device_onboarding/models.py Outdated Show resolved Hide resolved
nautobot_device_onboarding/models.py Outdated Show resolved Hide resolved
nautobot_device_onboarding/models.py Outdated Show resolved Hide resolved
nautobot_device_onboarding/views.py Outdated Show resolved Hide resolved
Copy link
Contributor

@mzbroch mzbroch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please squash all your commits into one indicating the scope of PR.

…teger labels to allow sorting in order of creation.
@mzbroch mzbroch requested review from glennmatthews and removed request for dgarros September 7, 2021 09:25
@mzbroch mzbroch merged commit c1c92b4 into nautobot:develop Sep 8, 2021
@mzbroch mzbroch changed the title Update to OnboardingTask tasks views and models to replace UUID with … Label attribute for sorting and identifying OnboaringTasks Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants