Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Plugin Dependencies #45

Merged
merged 2 commits into from Jul 30, 2022
Merged

Update Plugin Dependencies #45

merged 2 commits into from Jul 30, 2022

Conversation

mzbroch
Copy link
Contributor

@mzbroch mzbroch commented Jul 29, 2022

  • Remove Napalm 3.x constraint and allow for Napalm 4.x
  • Fix Netmiko 4x imports (new import compatible with Netmiko 3.x and 4.x)
  • Poetry Lock updates

@mzbroch mzbroch mentioned this pull request Jul 29, 2022
Closed
scetron
scetron reviewed Jul 29, 2022
View reviewed changes
pyproject.toml
@@ -19,7 +19,7 @@ packages = [

[tool.poetry.dependencies]
python = "^3.7"
napalm = ">=2.5.0, <4"
napalm = ">=2.5.0, <5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the new netmiko imports require a minimum version bump?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Netmiko imports have historically been defined in a wrong way and are not necessarily related to the napalm 4.
We're fixing the imports and allowing for netmiko/napalm 4 separately.

@mzbroch mzbroch merged commit d10a582 into develop Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scetron scetron scetron left review comments

@nniehoff nniehoff nniehoff approved these changes

@pszulczewski pszulczewski pszulczewski approved these changes

@glennmatthews glennmatthews Awaiting requested review from glennmatthews glennmatthews is a code owner

@itdependsnetworks itdependsnetworks Awaiting requested review from itdependsnetworks

@jvanderaa jvanderaa Awaiting requested review from jvanderaa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mzbroch @scetron @nniehoff @pszulczewski