Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.0 Changes #80

Merged
merged 8 commits into from
Aug 31, 2022
Merged

v1.0.0 Changes #80

merged 8 commits into from
Aug 31, 2022

Conversation

whitej6
Copy link
Contributor

@whitej6 whitej6 commented Aug 26, 2022

No description provided.

@whitej6 whitej6 changed the title Draft: Beta 4 changes Beta 4 changes Aug 28, 2022
@whitej6 whitej6 changed the title Beta 4 changes v1.0.0 Changes Aug 28, 2022
@@ -1,6 +1,6 @@
[tool.poetry]
name = "nautobot-firewall-models"
version = "0.1.0-beta.3"
version = "1.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps start with version = "1.0.0-beta.1"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be the 4th beta and not gotten much feedback from the community. I'm thinking beta release is holding adoption back. I'm also fairly confident in the quality of the release

Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@whitej6 whitej6 merged commit ccdf8b6 into develop Aug 31, 2022
@whitej6 whitej6 deleted the beta4 branch August 31, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants