Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings Detail View missing DG #466

Closed
jeffkala opened this issue Apr 11, 2023 · 1 comment · Fixed by #470
Closed

Settings Detail View missing DG #466

jeffkala opened this issue Apr 11, 2023 · 1 comment · Fixed by #470

Comments

@jeffkala
Copy link
Contributor

Environment

  • Python version: 3.8
  • Nautobot version: 1.5
  • nautobot-golden-config version: latest

With updates for GC to use DGs in the settings to define scope, it wasn't added to the settings detail view. So you must go to edit mode to see which DG is associated with a setting.

Steps to Reproduce

  1. demo.nautobot.com
  2. GC --> Settings
  3. Click default GC setting, loads the detail view without DG showing.

Expected Behavior

DG should show in the detail view for easier understandability on which DG is tied to that setting.

Observed Behavior

DG is missing from detail view.

@jeffkala
Copy link
Contributor Author

To augment, I do see where DG is specified now in the detail view. However I don't find it to follow the normal pattern. Would suggest we have a seperate tr for DG and the scope def that is there now.

jeffkala added a commit that referenced this issue Apr 14, 2023
itdependsnetworks pushed a commit that referenced this issue Apr 14, 2023
* ehancment to settings view: fixes #466

* implement PR review comments
jmpettit pushed a commit to jmpettit/nautobot-app-golden-config that referenced this issue Jan 30, 2024
* ehancment to settings view: fixes nautobot#466

* implement PR review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant