Use context manager with Nornir plays

[itdependsnetworks]

No description provided.

[glennmatthews]

Changing to context managers makes sense to me and seems like a logical improvement. I noticed with this change you are now reraising the original error instead of raising a new NornirNautobotException() - just checking whether that's an intentional change, and what if any consequences does that change have? (I.e., does whatever is calling these functions need to change from an except NornirNautobotException to an except Exception, things like that?)

[itdependsnetworks]

It was a purposeful thing, upon thinking about it, why wouldn't we want to log the message no matter the error. This seemed like a logical way to do it. There may be some situations where you get multiple messages, but I thought it would be an overall improvement.

[racsoce]

Thanks, this also solves the issue with leaving open ssh connections to the devices while doing the Backup Configurations by doing the close_connections() by the context, I just tested and is working good 👍
I was writing the Issue recommending the line nornir_obj.close_connections(nornir_obj.inventory.hosts) but this is the best fix 👍 :-)

[itdependsnetworks]

Yea, I should have been more clear that this was the intention of the PR, and should probably follow up with some documentation on the potential issue.