Stopping point linter and viewset updates #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkala
reviewed
Apr 14, 2023
itdependsnetworks
force-pushed
the
viewsets
branch
from
349c25f
to
9b0cc73
Compare
jeffkala
reviewed
Apr 17, 2023
jeffkala
approved these changes
Apr 17, 2023
|
During testing noticing that on Rules, Features, Replacements, Removals, the "add" views have duplicated |
looks like this must have been fixed in 1.5.x, tested again in 1.5.4 and it doesnt' show this any longer. |
|
Been playing with this for awhile now, seems great and working as expected. One thing that I'm not seeing is buttons on the |
jeffkala
reviewed
Apr 28, 2023
nautobot_golden_config/templates/nautobot_golden_config/compliancefeature_retrieve.html
Show resolved
Hide resolved
…ancefeature_retrieve.html Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com>
|
Now that the buttons issue is fixed everything else with this PR continues to function as expected. Caveat is |
|
Agreed. Will do that before next release |
jmpettit
pushed a commit
to jmpettit/nautobot-app-golden-config
that referenced
this pull request
Jan 30, 2024
* Stopping point linter and viewset updates * More updates * pylint updates * Update nautobot_golden_config/templates/nautobot_golden_config/compliancefeature_retrieve.html Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com> --------- Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.