Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deepdiff dependency. #498

Merged
merged 1 commit into from Jun 14, 2023

Conversation

Kircheneer
Copy link
Contributor

Currently, poetry parses this dependency as >=6.2.0 which means 5.x is forbidden - this causing problems downstream in other plugins.

@Kircheneer
Copy link
Contributor Author

poetry error message with "proof":

Because no versions of nautobot-plugin-operational-compliance match >0.0.1.dev39+git.e1eecd56,<0.0.2
   and nautobot-plugin-operational-compliance (0.0.1.dev39+git.e1eecd56) depends on jdiff (>=0.0.1,<0.0.2), nautobot-plugin-operational-compliance (>=0.0.1.dev39+git.e1eecd56,<0.0.2) requires jdiff (>=0.0.1,<0.0.2).
  And because no versions of jdiff match >0.0.1,<0.0.2, nautobot-plugin-operational-compliance (>=0.0.1.dev39+git.e1eecd56,<0.0.2) requires jdiff (0.0.1).
  And because jdiff (0.0.1) depends on deepdiff (>=5.5.0,<6.0.0)
   and nautobot-golden-config (1.4.1) depends on deepdiff (>=6.2.0), nautobot-plugin-operational-compliance (>=0.0.1.dev39+git.e1eecd56,<0.0.2) is incompatible with nautobot-golden-config (1.4.1).
  So, because nautobot-db-systel depends on both nautobot-golden-config (1.4.1) and nautobot-plugin-operational-compliance (^0.0.1.dev39+git.e1eecd56), version solving failed.

@jeffkala
Copy link
Contributor

@Kircheneer Does this still allow for #434

@@ -30,7 +30,7 @@ packages = [

[tool.poetry.dependencies]
python = "^3.7"
deepdiff = ">=5.5.0,>=6.2.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a reason this was put in, see @chadell for details. It should be something like ">=5.5.0,<6.99.0". Ideally it would account for not using 6.0.x and 6.1.x as well, but not sure if it matters or could be done.

The lock file should also be update for this (and only this) dependency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to allow exactly this behaviour.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this is right now, would say that 6.0 and 6.1 are not listed in pypi release history at all.

@Kircheneer
Copy link
Contributor Author

@Kircheneer Does this still allow for #434

Yes!

@@ -30,7 +30,7 @@ packages = [

[tool.poetry.dependencies]
python = "^3.7"
deepdiff = ">=5.5.0,>=6.2.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this is right now, would say that 6.0 and 6.1 are not listed in pypi release history at all.

@jeffkala jeffkala merged commit d7a404e into nautobot:develop Jun 14, 2023
16 checks passed
jmpettit pushed a commit to jmpettit/nautobot-app-golden-config that referenced this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants