New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deepdiff dependency. #498
Fix deepdiff dependency. #498
Conversation
|
@Kircheneer Does this still allow for #434 |
@@ -30,7 +30,7 @@ packages = [ | |||
|
|||
[tool.poetry.dependencies] | |||
python = "^3.7" | |||
deepdiff = ">=5.5.0,>=6.2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a reason this was put in, see @chadell for details. It should be something like ">=5.5.0,<6.99.0"
. Ideally it would account for not using 6.0.x and 6.1.x as well, but not sure if it matters or could be done.
The lock file should also be update for this (and only this) dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it to allow exactly this behaviour.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think this is right now, would say that 6.0 and 6.1 are not listed in pypi release history at all.
d61135a
to
58bc4da
Compare
Yes! |
@@ -30,7 +30,7 @@ packages = [ | |||
|
|||
[tool.poetry.dependencies] | |||
python = "^3.7" | |||
deepdiff = ">=5.5.0,>=6.2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think this is right now, would say that 6.0 and 6.1 are not listed in pypi release history at all.
Currently, poetry parses this dependency as >=6.2.0 which means 5.x is forbidden - this causing problems downstream in other plugins.