-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error handling improvements #6
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
glennmatthews
commented
Mar 5, 2021
•
edited
Loading
edited
- Catch Django ValidationError when creating/updating Nautobot data. Fixes ValidationError crash on rack import #4
- Catch Pydantic ValidationError when creating/updating internal data model. Fixes pydantic.error_wrappers.ValidationError crash on device import #5
- Add ObjectNotFound error handling for GenericForeignKey fields. Fixes Command errors out with ObjectNotFound exception #2
- Enable importing data exported from NetBox 2.10.5. Fixes Import of NetBox 2.10.5 JSON data #3
- Improve logging when errors are encountered during data loading
- Permit Devices with no name; add more fields to Device._identifiers to better distinguish device uniqueness
- Process templates after processing devices so that devices get initialized empty instead of pre-populated with components (since we will add the components ourselves)
- Fixed some incorrect definitions of the Service and PowerOutletTemplate models. Fixes Pydantic validation errors reported on import of Service and PowerOutletTemplate models #8.
- Populate the test data dump with additional data: Services, IPv6 addresses, and device component templates.
…o better distinguish device uniqueness
jathanism
approved these changes
Mar 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to see the issue I ran into addressed!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.