Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get All Devices To Parent Mapping #114

Merged
merged 6 commits into from
Sep 26, 2023
Merged

Conversation

snaselj
Copy link
Contributor

@snaselj snaselj commented Sep 21, 2023

Closes: NaN

What's Changed

  • Added Nautobot ORM method reading all devices and mapping it to the location hierarchy.

@snaselj
Copy link
Contributor Author

snaselj commented Sep 21, 2023

Is this going the right direction? @itdependsnetworks

@snaselj snaselj marked this pull request as ready for review September 26, 2023 03:52
@itdependsnetworks
Copy link
Contributor

one minor comment, but looks good! Can you provide an example dictionary that is produced via get_all_devices_to_parent_mapping?

@snaselj
Copy link
Contributor Author

snaselj commented Sep 26, 2023

one minor comment, but looks good! Can you provide an example dictionary that is produced via get_all_devices_to_parent_mapping?

An example is in tests here: https://github.com/nautobot/nautobot-plugin-nornir/pull/114/files#diff-c3b6436c4fcb927a0f934c5cd33237849f37b22b5c0005864c42f80f0868e7bdR85

@itdependsnetworks
Copy link
Contributor

I don't have further comments on the code, can you just update the docs to reflect? https://github.com/nautobot/nautobot-plugin-nornir/blob/develop/docs/user/app_feature_inventory.md#inventory-groupings

@snaselj
Copy link
Contributor Author

snaselj commented Sep 26, 2023

I don't have further comments on the code, can you just update the docs to reflect? https://github.com/nautobot/nautobot-plugin-nornir/blob/develop/docs/user/app_feature_inventory.md#inventory-groupings

Fixed

@itdependsnetworks itdependsnetworks merged commit 661b3ed into next-2.0 Sep 26, 2023
14 checks passed
itdependsnetworks added a commit that referenced this pull request Oct 1, 2023
* Fix deref syntax
* Update nautobot to v.2.0.2
* update site and device_role in nautobot_orm
* replace slug field
* update tests and build
* update repo to nautobot rc1
* Extend unittests
* Bump up to rc2 due to permission bug.
* Update docs
* Prep for next-2.0
* Update location to use .natural_slug and bump up to NB rc.3
* Update unittests
* Get All Devices To Parent Mapping (#114)
* feat: All devices to locations mapping
* doc: Update inventory documentation
* Ensure network driver is set, fix ConnectionOptions
* Update Nautobot RC compatibility (#116)
* initial release prep, still pending nornir-nautobot & poetry lock before merging
* Add Migration guide, remove dispatcher_mapping, update docs on Location settings, add settings check, add foundation for troubleshooting framework
* Update links and migration guide name
* Fix missing verify settings, make error messages more visible, add error code links to other repos
* bump depedency versions
* remove reference to deleted doc
* minor doc update
* update ci.yml

---------

Co-authored-by: Network to Code <federico.olivieri@networktocode.com>
Co-authored-by: pszulczewski <patryk@szulczewski.eu>
Co-authored-by: itdependsnetworks <ken@celenza.org>
Co-authored-by: Jan Snasel <jan.snasel@networktocode.com>
Co-authored-by: Bryan Culver <31187+bryanculver@users.noreply.github.com>
@itdependsnetworks itdependsnetworks deleted the u/snaselj-groups branch October 2, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants