Fix/issue64 - added fallthrough in error handling #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 16, 2024 10:12
specified in any of the elifs.
|
CI is failing unrelated to your changes, we need to bring in the fix from nautobot/cookiecutter-nautobot-app#111. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The boto3 call to get the secret value is wrapped in a try/except. The except block has a switch statement to raise different exceptions based on the error content. There was no fallthrough for the switch, so errors that were not explicitly defined were masked behind a subsequent error about the secret_value being referenced before it was assigned.