Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aws ssm parameter store #55

Merged
merged 14 commits into from
Apr 19, 2023
Merged

Aws ssm parameter store #55

merged 14 commits into from
Apr 19, 2023

Conversation

kacem-expereo
Copy link
Contributor

Hi Team, as proposed in #51
I propose to use Parameter Store as a new Secret manager source.
Parameter store is 8 times cheaper than Secret manager and can be used as a key/pair storage using a simple json as follows:
{"password": "SecretToStore"}

The key here is 'password' , provider 'parameter store' and region to be defined accordingly.
Test coverage is 91%
A function "get_value_for_secret(secret)" allows other plugins to fetch the secret from SSM.
Parameter store requires exactly the same setup as Secret Manager.

Thank you in advance for your time.

@jathanism
Copy link
Contributor

Hi there @kacem-expereo. Thank you for the contribution! Thank you for your patience as we've been all hands on deck working on Nautobot v2 and external contributions have been difficult to balance.

README.md Outdated
@@ -60,9 +60,9 @@ For this plugin to operate you must install at least one of the dependent librar

**You must install the dependencies for at least one of the supported secrets providers or a `RuntimeError` will be raised.**

#### AWS Secrets Manager
#### AWS Secrets Manager, AWS System Manager Parameter Store
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having both names in the same heading is a bit awkward to me. Can you please change this to just "AWS" and then add a sentence here to the effect of:

"AWS Secrets Manager and System Manager Parameter Store are supported."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can you please add a row for "AWS System Manager Parameter Store" to the table under the "Supported Secrets Backends" heading at the top of this file?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this suggestion. Also it looks like System Manager should be Systems Manager throughout?

README.md Outdated Show resolved Hide resolved
nautobot_secrets_providers/providers/__init__.py Outdated Show resolved Hide resolved
nautobot_secrets_providers/providers/aws_ssm.py Outdated Show resolved Hide resolved
@bryanculver bryanculver requested a review from a team as a code owner April 19, 2023 13:40
nautobot_secrets_providers/providers/__init__.py Outdated Show resolved Hide resolved
README.md Outdated
@@ -60,9 +60,9 @@ For this plugin to operate you must install at least one of the dependent librar

**You must install the dependencies for at least one of the supported secrets providers or a `RuntimeError` will be raised.**

#### AWS Secrets Manager
#### AWS Secrets Manager, AWS System Manager Parameter Store
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this suggestion. Also it looks like System Manager should be Systems Manager throughout?

nautobot_secrets_providers/providers/aws.py Outdated Show resolved Hide resolved
nautobot_secrets_providers/providers/aws.py Outdated Show resolved Hide resolved
nautobot_secrets_providers/providers/aws.py Outdated Show resolved Hide resolved
nautobot_secrets_providers/tests/test_providers.py Outdated Show resolved Hide resolved
nautobot_secrets_providers/tests/test_providers.py Outdated Show resolved Hide resolved
@bryanculver bryanculver dismissed jathanism’s stale review April 19, 2023 15:22

Feedback addresed.

@bryanculver bryanculver merged commit cd70bf6 into nautobot:develop Apr 19, 2023
17 checks passed
@kacem-expereo kacem-expereo deleted the aws_ssm_parameter_store branch April 20, 2023 11:20
@kacem-expereo
Copy link
Contributor Author

Thanks @bryanculver @glennmatthews ! No worries I've been following your work on nautobot v2 as well J
I'll happily switch to v1.4.0 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants