Add API Endpoints #143
Add API Endpoints #143
Conversation
|
|
||
| User = get_user_model() | ||
|
|
||
|
|
||
| class SyncAPITest(APIViewTestCases.APIViewTestCase): # pylint: disable=too-many-ancestors |
There was a problem hiding this comment.
Do we not support all the "Not implemented" ones? Shouldn't for example deletion be supported via the API?
There was a problem hiding this comment.
I think some of the tests are certainly valid. I just wasn't sure how to go about actually testing them. I can work on building them out though. This was meant as an initial stab at adding the API endpoints to satisfy the referenced issue and to also get ready for the Nautobot 2.0 React UI.
There was a problem hiding this comment.
I believe that we should get the unit tests in along with the feature, otherwise its unclear when/if the unit tests will ever be enabled
There was a problem hiding this comment.
Agreed, I just need time to figure out the tests. I'm not familiar with how the API unit tests work so still working through that.
There was a problem hiding this comment.
Here you should use separate subclasses of APIViewTestCases as this is a read-only API. That should cut down on the necessary @skip annotations.
| pass | ||
|
|
||
|
|
||
| class SyncLogEntryAPITest(APIViewTestCases.APIViewTestCase): # pylint: disable=too-many-ancestors |
There was a problem hiding this comment.
Same thing about the different base class here since this is also read-only
|
Putting this on hold until I have time to work on the tests after the 2.0 release. |
Kircheneer
added
the
status: action required
jdrew82
force-pushed
the
feat-api_endpoints
branch
from
7744f3b
to
0533fbb
Compare
This is adding initial skeleton required for serving the Sync and SyncLogEntry objects through the API.
jdrew82
force-pushed
the
feat-api_endpoints
branch
from
0533fbb
to
db07239
Compare
This PR is for addressing #38 to make the Sync and SyncLogEntry objects available via API endpoints.