Validate Default Settings Exist for CVP Integration And Fix DeviceRole attribute. #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdrew82
added
type: bug
jdrew82
changed the title
|
This should address the bug that was mentioned in #266 for the device_role attribute. I also found a potential bug in Infoblox integration with the CustomField key possibly having a dash instead of underscores so included fix for that. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue mentioned in #266 where the default settings not being defined causes the Job to crash. I've added checks for the essential settings and raise a MissingConfigSetting exception if not found. This should cause the Job to fail also in 2.0.