This repository has been archived by the owner on Sep 7, 2023. It is now read-only.
End-to-End Path FIx #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadell
reviewed
Sep 13, 2021
ipfabric/ipfabric.py
Outdated
| edge["dstAddr"], | ||
| edge["tlabel"], | ||
| nodes.get(edge["target"], {}).get("hostname"), | ||
| forwarding_type or "(empty)", |
There was a problem hiding this comment.
maybe use a CONSTANT instead of "(empty)" ?
so we could change it in one shoot later
There was a problem hiding this comment.
yes, good one. Will update.
chadell
reviewed
Sep 13, 2021
ipfabric/ipfabric.py
Outdated
| if dst_forwarding: | ||
| forwarding_type = dst_forwarding[0].get("search") | ||
|
|
||
| if src_forwarding and forwarding_type == "mpls": |
There was a problem hiding this comment.
I would group these 2 if statements in one:
if forwarding_type == "mpls":
if src_forwarding:
...
if dst_forwarding:
...just to group all the mpls stuff together
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the errors experienced when nodes have no forwarding.
The following items were accounted for in this fix:
Src FwdorDst Fwdto account for IP or MPLS forwarding.host,transitandcloudnodes that have very little forwarding information(empty)like the web application for null fields