Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

Bugfix/version selection #83

Merged
merged 2 commits into from
Sep 1, 2021
Merged

Bugfix/version selection #83

merged 2 commits into from
Sep 1, 2021

Conversation

qduk
Copy link
Contributor

@qduk qduk commented Aug 30, 2021

No description provided.

@qduk
Copy link
Contributor Author

qduk commented Aug 30, 2021

I didn't update for linting. This should fix anytime next is chosen in the version prompt. I also thought about maybe grouping the versions? So you chose a major version (10, 9, 8 etc) and the another menu popped up with just those versions. Thoughts? The list isn't bad though since you can just type in what you want and it'll find it in the list.

@qduk qduk linked an issue Aug 30, 2021 that may be closed by this pull request
Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jdrew82
Copy link
Contributor

jdrew82 commented Aug 30, 2021

I didn't update for linting. This should fix anytime next is chosen in the version prompt. I also thought about maybe grouping the versions? So you chose a major version (10, 9, 8 etc) and the another menu popped up with just those versions. Thoughts? The list isn't bad though since you can just type in what you want and it'll find it in the list.

I like the idea but I think it'd negatively affect the ability to just specify the command from the command string. I don't forsee users needing to traverse a large number of versions though. I would think typically they tend to go for newer which are already at the top of the list.

@qduk qduk merged commit b7c0ee7 into develop Sep 1, 2021
@matt852 matt852 deleted the bugfix/version_selection branch December 7, 2021 21:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with upload software version selection
2 participants