New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation for Settings sot_agg_query #445
Conversation
This adds validation to the GoldenConfigSetting clean method for requiring sot_agg_query to have a value when the Plugin Config has SOTAGG_ENABLED set to True. This is to address the issue where the Golden Config home page has an SOTAGG icon with an invalid link.
@itdependsnetworks @jeffkala is this a valid solution for #393 ? If so, I will work on adding a couple of test cases. |
I think so, @jeffkala any issues? |
good on my end |
Can you confirm that it works as expected in the ui |
@itdependsnetworks this now has best effort to prevent the case from #393 and then shows |
@itdependsnetworks I have updated the "error" message and added tests for the updates. |
* Add validation for Settings sot_agg_query This adds validation to the GoldenConfigSetting clean method for requiring sot_agg_query to have a value when the Plugin Config has SOTAGG_ENABLED set to True. This is to address the issue where the Golden Config home page has an SOTAGG icon with an invalid link. * Default sot_agg_query results to a dict with an error message The sotagg detail view raised an exception when ENABLE_SOTAGG was set to True but the GoldenConfigSetting did not define a sot_agg_query. This is still a possible scenario if the Config toggles the ENABLE_SOTAGG config, so now this page will render with a message explaining that the sot_agg_query needs to be defined.
This adds validation to the GoldenConfigSetting clean method for requiring sot_agg_query to have a value when the Plugin Config has SOTAGG_ENABLED set to True. This is to address the issue where the Golden Config home page has an SOTAGG icon with an invalid link.