Add validation for Settings sot_agg_query #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds validation to the GoldenConfigSetting clean method for requiring sot_agg_query to have a value when the Plugin Config has SOTAGG_ENABLED set to True. This is to address the issue where the Golden Config home page has an SOTAGG icon with an invalid link.
jmcgill298
requested review from
itdependsnetworks,
jeffkala and
nkallergis
as code owners
|
@itdependsnetworks @jeffkala is this a valid solution for #393 ? If so, I will work on adding a couple of test cases. |
|
I think so, @jeffkala any issues? |
jeffkala
approved these changes
Mar 8, 2023
|
good on my end |
|
Can you confirm that it works as expected in the ui |
|
@itdependsnetworks this now has best effort to prevent the case from #393 and then shows |
|
|
jeffkala
reviewed
Mar 10, 2023
|
@itdependsnetworks I have updated the "error" message and added tests for the updates. |
itdependsnetworks
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds validation to the GoldenConfigSetting clean method for requiring sot_agg_query to have a value when the Plugin Config has SOTAGG_ENABLED set to True. This is to address the issue where the Golden Config home page has an SOTAGG icon with an invalid link.