This repository has been archived by the owner on Oct 25, 2023. It is now read-only.
Prefix VLAN Assignment Fix #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the hasattr function for checking if a VLAN is assigned to a Prefix so instead need to check if prefix.vlan is None.
FragmentedPacket
approved these changes
Sep 8, 2022
|
Do we have testing strategies or patterns for our SSoT apps? It seems like it would be good to start being able to add tests for these bug fixes. |
qduk
approved these changes
Sep 8, 2022
I have a pattern for testing the non-Nautobot adapter loading for another project. Need to work on building one for the Nautobot side. Biggest problem is need some fixtures built out for the Nautobot side to mock new import and updates. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for fixing the issue raised in #100. Just needed to change the check of whether a Prefix has a VLAN assigned.