Skip to content

Commit

Permalink
Fixed upstream testing workflow not failing when a step fails (#5590)
Browse files Browse the repository at this point in the history
  • Loading branch information
gsnider2195 committed Apr 17, 2024
1 parent 93c9301 commit edf50fc
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 0 additions & 1 deletion .github/workflows/plugin_upstream_testing_base.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ env:

jobs:
unittest:
continue-on-error: true
strategy:
fail-fast: false
matrix:
Expand Down
1 change: 1 addition & 0 deletions changes/5590.housekeeping
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed upstream testing workflows showing successful when one of the steps fail.

0 comments on commit edf50fc

Please sign in to comment.