Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Images: Add A major/minor Docker image that rolls up the patch versions into it #1242

Closed
FragmentedPacket opened this issue Jan 7, 2022 · 1 comment · Fixed by #1444
Assignees
Labels
type: feature Introduction of new or enhanced functionality to the application

Comments

@FragmentedPacket
Copy link
Contributor

Proposed Functionality

I'm going to try and explain this the best I can.

Currently, we're publishing Docker containers for the exact specific version, e.g. 1.2.2. In addition to those, I would like to see a 1.X tag that incorporates the latest patch version into it on each release of a patch. For instance, when 1.2.3 is release, a new image is also pushed up to 1.2 that now incorporates the latest patch version.

This can be extended to major versions down the road as well and hopefully it's pretty simple to tag and push up within our current process. Tagging @nniehoff though for his expert opinion

Use Case

This functionality will help CI/CD pipelines for our Nautobot plugins where we can specify the minor versions to test against rather than list out a ton of patch version or not have to update pipeline files to test against the latest versions.

Our Nautobot plugin CI/CD matrix would only have to be: [1.1, 1.2] with this new change.

Example #1: https://github.com/nautobot/nautobot-plugin-chatops-grafana/blob/develop/.github/workflows/ci.yml#L150

External Dependencies

Docker publishing pipeline

@nniehoff
Copy link
Contributor

nniehoff commented Jan 7, 2022

The more appropriate place would be in the release.yml provided by #1218. This should be as simple as adding tags to the docker/metadata-actions. I'll work on this once we get #1218 done.

@glennmatthews glennmatthews added the type: feature Introduction of new or enhanced functionality to the application label Jan 10, 2022
bryanculver added a commit that referenced this issue Mar 4, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: feature Introduction of new or enhanced functionality to the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants