Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI invalid information displayed when clicking on "Change Log" tab #1253

Closed
jifox opened this issue Jan 10, 2022 · 1 comment · Fixed by #1257
Closed

UI invalid information displayed when clicking on "Change Log" tab #1253

jifox opened this issue Jan 10, 2022 · 1 comment · Fixed by #1257
Labels
good first issue Great issues for newcomers! type: bug Something isn't working as expected

Comments

@jifox
Copy link
Contributor

jifox commented Jan 10, 2022

Environment

  • Python version: 3.9
  • Nautobot version: 725013287a8b (v1.2.3)

Steps to Reproduce

  1. Select a "Device Types" entry (https://localhost:8443/dcim/device-types/fe088c13-4f37-42ff-b476-cd9e8c02274b/)
  2. click on tab "Change Log" (https://localhost:8443/dcim/device-types/fe088c13-4f37-42ff-b476-cd9e8c02274b/changelog/)
  3. click on Tag "Device Type" (https://localhost:8443/dcim/device-types/fe088c13-4f37-42ff-b476-cd9e8c02274b/changelog/#tab_main)

Expected Behavior

The selected info should be displayed.

It seems that the url is not correct (.../changelog/#tab_main instead of '.../')

Same problem when selecting "Advanced" Tab (https://localhost:8443/dcim/device-types/fe088c13-4f37-42ff-b476-cd9e8c02274b/changelog/#tab_advanced)

Observed Behavior

After clicking the "Change Log" page is sill be displayed

image

@glennmatthews glennmatthews added the type: bug Something isn't working as expected label Jan 10, 2022
@glennmatthews
Copy link
Contributor

Thanks for the report! I can confirm the issue. From a quick look at the code, it looks like the issue is that nautobot/dcim/templates/dcim/devicetype.html has its own custom block javascript block, which is replacing rather than augmenting the javascript defined in the base nautobot/core/templates/generic/object_detail.html template. Fixing this should be as simple as adding a {{ block.super }} statement to the javascript block in devicetype.html so that it inherits the base javascript as well.

@glennmatthews glennmatthews added good first issue Great issues for newcomers! status: accepted labels Jan 10, 2022
@jifox jifox changed the title UI invalid information displayed when cliecking on "Change Log" tab UI invalid information displayed when clicking on "Change Log" tab Jan 10, 2022
jifox added a commit to jifox/nautobot that referenced this issue Jan 10, 2022
@jifox jifox mentioned this issue Jan 10, 2022
glennmatthews pushed a commit that referenced this issue Jan 10, 2022
glennmatthews added a commit that referenced this issue Jan 10, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Great issues for newcomers! type: bug Something isn't working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants