Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra value secrets_group in header during device csv export #1469

Closed
jakubkrysl opened this issue Mar 9, 2022 · 1 comment · Fixed by #1472
Closed

Extra value secrets_group in header during device csv export #1469

jakubkrysl opened this issue Mar 9, 2022 · 1 comment · Fixed by #1472
Assignees
Labels
good first issue Great issues for newcomers! type: bug Something isn't working as expected

Comments

@jakubkrysl
Copy link

Environment

  • Python version: 3.6.15
  • Nautobot version: v1.2.7

When exporting csv in UI for device, there is extra value in header that has no data. This results in all data after it being shifted left by 1 position.
Easily reproducible on demo.nautobot.com, the device needs to have some data in comments (as there are no custom fields for devices)
Create CSV export from this view: https://demo.nautobot.com/dcim/devices/?q=+ams01-dist-01
image
The data from comment is shifted to secrets_group column.

Steps to Reproduce

  1. Have device with data in comment or some custom field
  2. Export CSV from UI
  3. Check if data are in correct columns

Expected Behavior

Data in correct columns

Observed Behavior

Data shifted left by 1 column because header contains extra column secrets_group that has no data generated for it

@glennmatthews
Copy link
Contributor

Thanks for the report! This appears to just be a missing entry in the Device.to_csv() method, should be a very straightforward fix.

@glennmatthews glennmatthews added good first issue Great issues for newcomers! status: accepted type: bug Something isn't working as expected labels Mar 9, 2022
ubajze added a commit to ubajze/nautobot that referenced this issue Mar 10, 2022
@ubajze ubajze mentioned this issue Mar 10, 2022
glennmatthews pushed a commit that referenced this issue Mar 14, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Great issues for newcomers! type: bug Something isn't working as expected
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants